Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/cmd/goimports: strict ordering of local packages #32301

Open
romikser opened this issue May 29, 2019 · 2 comments

Comments

@romikser
Copy link

commented May 29, 2019

Support for multiple packages was added here.
It would be good to be able to specify strict order of local packages.
For example if I specify local packages as mycompany.com/foo,mycompany.com/bar mycompany.com/foo imports will always be placed above mycompany.com/bar packages.

@gopherbot gopherbot added this to the Unreleased milestone May 29, 2019

@julieqiu julieqiu changed the title x/tools/cmd/goimports: Strict ordering of local packages x/tools/cmd/goimports: strict ordering of local packages May 29, 2019

@julieqiu

This comment has been minimized.

Copy link

commented May 29, 2019

@josharian

This comment has been minimized.

Copy link
Contributor

commented Jun 17, 2019

I dunno; I'd rather not. The less configuration, the better. As it stands, you won't get code churn if two people set up their flags differently.

@gopherbot gopherbot added the Tools label Sep 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.