net/http: make Transport ignore 408 timeout messages from server #32310
Comments
Change https://golang.org/cl/179457 mentions this issue: |
@gopherbot, please backport. |
This was referenced May 31, 2019
Backport issue(s) opened: #32366 (for 1.11), #32367 (for 1.12). Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://golang.org/wiki/MinorReleases. |
Change https://golang.org/cl/181239 mentions this issue: |
gopherbot
pushed a commit
that referenced
this issue
Jun 7, 2019
…err on server 408 reply HTTP 408 responses now exist and are seen in the wild (e.g. from Google's GFE), so make Go's HTTP client not spam about them when seen. They're normal (now). Fixes #32367 Updates #32310 Change-Id: I558eb4654960c74cf20db1902ccaae13d03310f6 Reviewed-on: https://go-review.googlesource.com/c/go/+/179457 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> (cherry picked from commit ba66d89) Reviewed-on: https://go-review.googlesource.com/c/go/+/181239 Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Apparently HTTP 408 is a thing:
https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/408
https://tools.ietf.org/html/rfc7231#section-6.5.7
I learned of this because I just saw this in some logs from our ppc64 buildlet. I suspect the TCP connection was to Google's GFE to Google Cloud Storage.
We should silently ignore those.
The text was updated successfully, but these errors were encountered: