-
Notifications
You must be signed in to change notification settings - Fork 18.8k
Closed
Labels
FrozenDueToAgeNeedsInvestigationSomeone must examine and confirm this is a valid issue and not a duplicate of an existing one.Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.OS-Windows
Milestone
Description
I am using
commit ad28b68e88f12448a1685d038ffea87bbbb34148 (HEAD -> master, origin/master, origin/HEAD)
Author: Takuto Ikuta <tikuta@google.com>
Date: Fri May 24 22:45:01 2019 +0900
windows: make zsyscall_windows.go generatable on non-WSL env
mkerrors.bash requires a Windows host, as it hard-codes paths like
/mnt/c/Program Files (x86)/Windows Kits.
But this does not allow to generate in non-WSL env.
Currently mkerrors.bash runs earlier than mksyscall_windows.go
when we run `go generate` and it fails on non-WSL env.
So zsyscall_windows.go is not generated in that case.
To fix that, I reoreder of code generation in this CL so that we can
generate zsyscall_windows.go in non-WSL env.
Also update error message in mkerrors.bash.
Change-Id: I04eccdbfe1e1ff56f8c405250f0724000d66d579
Reviewed-on: https://go-review.googlesource.com/c/sys/+/178781
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
version of x/sys repo on windows.
What did you do?
I run these commands
cd %GOPATH%\src\golang.org\x\sys\windows
go generate
What did you expect to see?
I expected my commands to succeed.
What did you see instead?
They fail with this error
gen.go:9: running "./generate.bash": fork/exec ./generate.bash: %1 is not a valid Win32 application.
Alex
Metadata
Metadata
Assignees
Labels
FrozenDueToAgeNeedsInvestigationSomeone must examine and confirm this is a valid issue and not a duplicate of an existing one.Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.OS-Windows