Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: "cannot find module golang.org/x/sys/unix" when GOOS=illumos #32370

Open
jclulow opened this issue May 31, 2019 · 3 comments

Comments

Projects
None yet
3 participants
@jclulow
Copy link

commented May 31, 2019

I believe that the fix for #30888, applicable for GOOS=android, needs to cover the equivalence between the illumos and solaris in the same manner. It appears I missed this when adding the illumos build tag in #20603.

I built the latest master revision to make sure this is still an issue:

go version devel +2165452a37 Fri May 31 11:26:23 2019 +0000 illumos/amd64

(I get the "cannot find module golang.org/x/sys/unix" for an illumos/amd64 toolchain but not for a solaris/amd64 toolchain)

@jclulow

This comment has been minimized.

Copy link
Author

commented May 31, 2019

(I'm looking into this.)

@jclulow

This comment has been minimized.

Copy link
Author

commented May 31, 2019

In addition to the original fix for cross building for Android, it seems we need to amend the tags map constructed in cmd/go/internal/imports/tags.go. This probably also needs to happen for linux/android as well. I suspect it wasn't noticed there because people perhaps don't generally run a native Android toolchain?

@gopherbot

This comment has been minimized.

Copy link

commented May 31, 2019

Change https://golang.org/cl/179817 mentions this issue: cmd/go: recognise illumos suffix when constructing build list

@bcmills bcmills added this to the Go1.13 milestone Jun 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.