Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: strange autocompletion behaviour for function arguments #32375

Closed
stamblerre opened this issue May 31, 2019 · 6 comments
Closed

x/tools/gopls: strange autocompletion behaviour for function arguments #32375

stamblerre opened this issue May 31, 2019 · 6 comments

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented May 31, 2019

@muirdm

This comment has been minimized.

Copy link

@muirdm muirdm commented Jun 3, 2019

I can't reproduce this. Could you reproduce it @stamblerre?

@muirdm

This comment has been minimized.

Copy link

@muirdm muirdm commented Jun 5, 2019

@fotonmoton can you try upgrading gopls and see if you can still reproduce this? I wasn't able to reproduce.

@fotonmoton

This comment has been minimized.

Copy link

@fotonmoton fotonmoton commented Jun 5, 2019

@muirrn yeah, no problem, how can i do it? Just go get -u golang.org/x/tools/cmd/gopls will be sufficient? I'm a bit new to go :)

@fotonmoton

This comment has been minimized.

Copy link

@fotonmoton fotonmoton commented Jun 5, 2019

@muirrn get the same results. How can I supply a bit more info? and what information is needed? When I was installing vscode-go I install all go dependencies, maybe some packages in conflict with each other?

@stamblerre

This comment has been minimized.

Copy link
Contributor Author

@stamblerre stamblerre commented Jun 29, 2019

To update, run go get -u golang.org/x/tools/gopls@master.

@muirrn: I am actually able to reproduce this. Maybe this is something VSCode-specific, but quite clearly in the TextEdit there are no parentheses.

@stamblerre stamblerre changed the title x/tools/cmd/gopls: strange autocompletion behaviour for function arguments x/tools/gopls: strange autocompletion behaviour for function arguments Jul 2, 2019
@stamblerre stamblerre added help wanted and removed Suggested labels Aug 8, 2019
@stamblerre

This comment has been minimized.

Copy link
Contributor Author

@stamblerre stamblerre commented Oct 25, 2019

I'm no longer able to reproduce this issue with the more recent improvements to gopls. Thanks @muirrn!

Closing this issue now. @fotonmoton: Please open a new issue if something else comes up.

@stamblerre stamblerre closed this Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.