Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/tls: back RSA-PSS out of TLS 1.2 in Go 1.13 #32425

Open
FiloSottile opened this issue Jun 4, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@FiloSottile
Copy link
Member

commented Jun 4, 2019

8834353 enabled again RSA-PSS in TLS 1.2. Unfortunately, there are broken crypto.Signer implementations out there that do the wrong thing when asked to generate RSA-PSS signatures.

TLS 1.3 requires RSA-PSS, so there is no way around ripping this band-aid off, but partially because of this TLS 1.3 was opt-in in Go 1.12 and is opt-out in Go 1.13 (#30055). RSA-PSS in TLS 1.2 would just be enabled with no way to turn it off, and both adding another GODEBUG option, or making GODEBUG=tls13=0 impact TLS 1.2 feel wrong.

What finally tipped the scale is that #28660 provides a nice way for code to opt-out of RSA-PSS in TLS 1.2 if needed. Let's wait to force RSA-PSS in TLS 1.2 until Go 1.14, when TLS 1.3 is also forced on, and there is a code path to disabling it.

/cc @agl @rsc

@FiloSottile FiloSottile added this to the Go1.13 milestone Jun 4, 2019

@gopherbot

This comment has been minimized.

Copy link

commented Jun 13, 2019

Change https://golang.org/cl/182339 mentions this issue: crypto/tls: disable RSA-PSS in TLS 1.2 again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.