Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
x/tools/gopls: signatureHelp should return position info for signatures #32468
What version of Go are you using (
referenced this issue
Jun 6, 2019
I'll look at it when I get back, but seems likely.…
On Mon, Jun 10, 2019 at 6:23 PM Rebecca Stambler ***@***.***> wrote: @pjweinb <https://github.com/pjweinb>: Would it be possible for us to make this change in the protocol generator? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#32468?email_source=notifications&email_token=ABJIAIZM2K4AYCQ5KC754ILPZ3H4XA5CNFSM4HVIA6Q2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXLMV5Q#issuecomment-500615926>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABJIAI7FBDA2LK235VPDF7TPZ3H4XANCNFSM4HVIA6QQ> .
@stamblerre: could you add a float64 field to ParameterInformation in lsp/source/signature_help.go? It does't matter what you name it, but once it exists (and gets filled in), we can change line 57 in signature_help.go to use the new field in place of p.Label.