net/http: DetectContentType does not detect application/x-bzip2

[coreydaley]

What version of Go are you using (go version)?

$ go version
go version go1.12.5 linux/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output

$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/cdaley/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/cdaley/go"
GOPROXY=""
GORACE=""
GOROOT="/usr/lib/golang"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/golang/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/cdaley/Projects/github.com/offlinedocs/offlinedocs/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build110412641=/tmp/go-build -gno-record-gcc-switches"GOARCH="amd64"
GOBIN=""
GOCACHE="/home/cdaley/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/cdaley/go"
GOPROXY=""
GORACE=""
GOROOT="/usr/lib/golang"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/golang/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/cdaley/Projects/github.com/offlinedocs/offlinedocs/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build110412641=/tmp/go-build -gno-record-gcc-switches"

What did you do?

extracted the first 512 bytes of a bzip2 file and ran net/http.DetectContentType on it
https://play.golang.org/p/u4WBPl0bsMS

What did you expect to see?

application/x-bzip2

What did you see instead?

application/octet-stream

[gopherbot]

Change https://golang.org/cl/181420 mentions this issue: net/http: add application/x-bzip2 detection to DetectContentType

[odeke-em]

Thank you for filing this issue @coreydaley!

So we get the signatures from https://mimesniff.spec.whatwg.org/#zip-based-mime-type so perhaps let's first file an issue on the Github issues https://github.com/whatwg/mimesniff and once that's agreed upon we'll LGTM your CL. Thank you.

[odeke-em]

I am going to move this to the unreleased milestone since we are depending on browsers and the MIME working group to approve the signatures.

[bradfitz]

@odeke-em, Unreleased is for code that's not included in Go releases. I changed to Unplanned. We can do this if the upstream spec is updated.

[odeke-em]

Got it, thanks Brad!

…

On Mon, Oct 14, 2019 at 1:42 PM Brad Fitzpatrick ***@***.***> wrote: @odeke-em <https://github.com/odeke-em>, Unreleased is for code that's not included in Go releases. I changed to Unplanned. We can do this if the upstream spec is updated. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#32508?email_source=notifications&email_token=ABFL3V5DF64LIC2JHIJZQODQOTKUXA5CNFSM4HWLAZVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBGN3ZY#issuecomment-541908455>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABFL3VYA7TQU5DACSFQ3TL3QOTKUXANCNFSM4HWLAZVA> .