Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
x/build/cmd/coordinator: test packages in nested modules (in multi-module repositories) #32528
Right now, the trybots and post-submit builders assume there's only one module in each subrepository, and run
That means modules not at the root are not covered.
Somewhat related to #30233, because the
That might not be quite as bad as it seems. If the root module has
That said, we should probably have the builders look for
Here's how I expect this can be implemented.
I've tested the coordinator change for this issue on x/build CL 191018 and x/tools CL 191018 by restarting their trybots just now, and watched the build logs very closely. It appears to be working as intended, I'm not seeing any issues.
It successfully detected the 5 modules in the x/build repo:
And the 2 modules in the x/tools repo,
Here are build logs for various builds of the successful trybot run for CL 191018:
linux-amd64 (Go tip)
linux-amd64-race (Go tip)
windows-amd64-2016 (Go tip)
linux-amd64 (Go 1.13.x)
linux-amd64 (Go 1.12.x) - tests ran in GOPATH mode, module boundaries ignored
Search the build logs for ":: Running" to find
And here's the correctly failing trybot run for CL 182584. It has links to its build logs.