Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: `go get -u=patch golang.org/x/tools` broken at head #32537

Closed
bcmills opened this issue Jun 10, 2019 · 2 comments

Comments

Projects
None yet
3 participants
@bcmills
Copy link
Member

commented Jun 10, 2019

The fix for #26902 seems to have broken -u=patch when the command-line argument is a module that does not contain a package at its root.

$ gotip version
go version devel +323212b9 Sun Jun 9 16:23:11 2019 +0000 linux/amd64

$ mkdir example.com

$ cd example.com

example.com$ gotip mod init example.com
go: creating new go.mod: module example.com

example.com$ gotip get -u=patch golang.org/x/tools
go: finding golang.org/x/tools latest
go: downloading golang.org/x/tools v0.0.0-20190610194359-fe937a7521e5
go: extracting golang.org/x/tools v0.0.0-20190610194359-fe937a7521e5
go get golang.org/x/tools: module golang.org/x/tools@latest (v0.0.0-20190610194359-fe937a7521e5) found, but does not contain package golang.org/x/tools

CC @jayconrod @jba

@jayconrod

This comment has been minimized.

Copy link
Contributor

commented Jun 11, 2019

I believe CL 180337 should fix this. I'll verify and update the commit message.

@gopherbot

This comment has been minimized.

Copy link

commented Jun 11, 2019

Change https://golang.org/cl/180337 mentions this issue: cmd/go: avoid accidental downgrades in 'go get' with latest and patch

@gopherbot gopherbot closed this in 4c2ffd2 Jun 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.