Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/mobile: gomobile bind: add flag to disable package name prefix in iOS classes #32573

Open
ealymbaev opened this issue Jun 12, 2019 · 1 comment

Comments

Projects
None yet
4 participants
@ealymbaev
Copy link

commented Jun 12, 2019

What version of Go are you using (go version)?

$ go version
go version go1.12.5 darwin/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/ealymbaev/Library/Caches/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/ealymbaev/go"
GOPROXY=""
GORACE=""
GOROOT="/usr/local/Cellar/go/1.12.5/libexec"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.12.5/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/ealymbaev/projects/go-fee-rate-kit/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/k6/bvkt3fss5y16k_y3vyftfq1h0000gp/T/go-build635284137=/tmp/go-build -gno-record-gcc-switches -fno-common"

When binding an iOS framework with:

gomobile bind -target ios some-package

in generated header files all classes DO have prefix of package name. I tried using -prefix flag, but it adds even additional prefix to class names.

I need a way to remove package name prefix, so the class name remain exactly the same as in Go code.

@gopherbot gopherbot added this to the Unreleased milestone Jun 12, 2019

@gopherbot gopherbot added the mobile label Jun 12, 2019

@hyangah

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

Is it not possible to directly use the gobind instead of gomobile bind and replace/modify the generated names to your liking?

BTW we chose to include the package names in name generation because in Go, package names are important part of exported names (e.g. Go code uses fmt.Fprintf, not Fprintf), and even choosing the right package name is often discussed in various Go best-practice docs. e.g. https://blog.golang.org/package-names

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.