Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/cmd/gopls: use the internal goimports library #32585

Closed
stamblerre opened this issue Jun 12, 2019 · 1 comment
Closed

x/tools/cmd/gopls: use the internal goimports library #32585

stamblerre opened this issue Jun 12, 2019 · 1 comment
Assignees
Milestone

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Jun 12, 2019

From @heschik, regarding goimports speed: Switch from the public API in x/tools/imports to the private one in x/tools/internal/imports. That one lets you control the lifetime of the environment object, which contains all the caches.

/cc @suzmue

@gopherbot
Copy link

@gopherbot gopherbot commented Jun 28, 2019

Change https://golang.org/cl/184198 mentions this issue: internal/lsp, internal/imports: use the internal goimports library

@golang golang locked and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.