Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: jsonrpc worker goroutine can get stuck #32589

Closed
muirdm opened this issue Jun 13, 2019 · 3 comments
Closed

x/tools/gopls: jsonrpc worker goroutine can get stuck #32589

muirdm opened this issue Jun 13, 2019 · 3 comments
Labels
Milestone

Comments

@muirdm
Copy link

@muirdm muirdm commented Jun 13, 2019

My gopls got stuck with "no room in queue" errors because the "workspace/configuration" call gopls made to Emacs never got a response. Emacs didn't respond because I had an error in my config, but it seems like we either need a timeout or more goroutines to avoid getting stuck in the case the server doesn't respond properly.

/cc @ianthehat

@gopherbot gopherbot added this to the Unreleased milestone Jun 13, 2019
@gopherbot gopherbot added the gopls label Jun 13, 2019
@myitcv

This comment has been minimized.

Copy link
Member

@myitcv myitcv commented Jun 13, 2019

I'm not sure I'm a huge fan of timeouts.... they tend to mask underlying, bigger problems.

The "no room in queue" errors are a derivative error of the underlying in this case, correct?

@muirdm

This comment has been minimized.

Copy link
Author

@muirdm muirdm commented Jun 13, 2019

Yes, I got "no room in queue" because the worker goroutine was not reading off queue, so the queue filled up.

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Jun 27, 2019

Change https://golang.org/cl/183718 mentions this issue: internal/jsonrpc2: change the concurrency strategy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.