Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: allow parallel request processing #32629

Open
muirdm opened this issue Jun 14, 2019 · 0 comments
Assignees
Milestone

Comments

@muirdm
Copy link

@muirdm muirdm commented Jun 14, 2019

Currently all requests (e.g. signatureHelp, hover, complete, documentHighlight, etc) are processed synchronously, meaning they block subsequent requests/notifications. This includes the time they spend parsing and type checking, which can be significant. In particular, this is wasteful when a new didChange event comes in, since that "should" cancel all in-flight requests for that package, but currently it has to wait for them all to finish.

When gopls is ready for the extra complexity, @ianthehat says that these requests can change to do most of their work asynchronously.

@gopherbot gopherbot added this to the Unreleased milestone Jun 14, 2019
@gopherbot gopherbot added the gopls label Jun 14, 2019
@ianthehat ianthehat self-assigned this Jun 14, 2019
@gopherbot gopherbot added the Tools label Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.