Track tasks and feature requests
Join 36 million developers who use GitHub issues to help identify, assign, and keep track of the features and bug fixes your projects need.
Sign up for free See pricing for teams and enterprisesx/tools/gopls: allow parallel request processing #32629
Comments
gopherbot
added this to the Unreleased milestone
Jun 14, 2019
gopherbot
added
the
gopls
label
Jun 14, 2019
ianthehat
self-assigned this
Jun 14, 2019
ianthehat
added
the
FeatureRequest
label
Jun 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
muirrn commentedJun 14, 2019
Currently all requests (e.g. signatureHelp, hover, complete, documentHighlight, etc) are processed synchronously, meaning they block subsequent requests/notifications. This includes the time they spend parsing and type checking, which can be significant. In particular, this is wasteful when a new didChange event comes in, since that "should" cancel all in-flight requests for that package, but currently it has to wait for them all to finish.
When gopls is ready for the extra complexity, @ianthehat says that these requests can change to do most of their work asynchronously.