Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: blocking queue behavior can cause deadlocks #32631

Closed
muirdm opened this issue Jun 14, 2019 · 1 comment
Closed

x/tools/gopls: blocking queue behavior can cause deadlocks #32631

muirdm opened this issue Jun 14, 2019 · 1 comment
Labels
Milestone

Comments

@muirdm
Copy link

@muirdm muirdm commented Jun 14, 2019

Now that the gopls jsonrpc queue blocks when full instead of rejecting messages, I've started to get deadlocks starting gopls in Emacs:

  1. Emacs starts gopls
  2. Emacs sends tons of requests/notifications for all open buffers
  3. Somewhere in the middle of 2) gopls sends a configuration request to Emacs
  4. Emacs sends the response, but the gopls's queue is full so go gopls doesn't read it
  5. Deadlock (Emacs is waiting for responses to its requests, gopls is waiting for response to configuration request)

@ianthehat suggested we should either get rid of the configuration request altogether, or rejigger things so that it can be asynchronous.

@gopherbot gopherbot added this to the Unreleased milestone Jun 14, 2019
@gopherbot gopherbot added the gopls label Jun 14, 2019
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Jun 27, 2019

Change https://golang.org/cl/183718 mentions this issue: internal/jsonrpc2: change the concurrency strategy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.