Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime/race: external_cgo_thread passed unexpectedly in TestOutput #32653

Closed
cuonglm opened this issue Jun 17, 2019 · 5 comments
Closed

runtime/race: external_cgo_thread passed unexpectedly in TestOutput #32653

cuonglm opened this issue Jun 17, 2019 · 5 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.

Comments

@cuonglm
Copy link
Member

cuonglm commented Jun 17, 2019

https://storage.googleapis.com/go-build-log/63849344/linux-amd64-race_657c252c.log

Output extracted from test log:

--- FAIL: TestOutput (9.68s)
    output_test.go:76: failed test case external_cgo_thread, expect:
        ==================
        WARNING: DATA RACE
        Read at 0x[0-9,a-f]+ by main goroutine:
          main\.main\(\)
              .*/main\.go:34 \+0x[0-9,a-f]+
        
        Previous write at 0x[0-9,a-f]+ by goroutine [0-9]:
          main\.goCallback\(\)
              .*/main\.go:27 \+0x[0-9,a-f]+
          main._cgoexpwrap_[0-9a-z]+_goCallback\(\)
              .*_cgo_gotypes\.go:[0-9]+ \+0x[0-9,a-f]+
        
        Goroutine [0-9] \(running\) created at:
          runtime\.newextram\(\)
              .*/runtime/proc.go:[0-9]+ \+0x[0-9,a-f]+
        ==================
        got:
@katiehockman
Copy link
Contributor

Can you please provide more information on what action we should be taking with this issue report? It looks like this is just from a trybots run in https://go-review.googlesource.com/c/go/+/182561, and that the builders are passing for linux-amd64-race right now.

@katiehockman katiehockman added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Jun 18, 2019
@cuonglm
Copy link
Member Author

cuonglm commented Jun 19, 2019

@katiehockman it's a data race, so it can happen this time but not that time.

@katiehockman katiehockman changed the title runtime: pprof test data race runtime/pprof/internal/profile: TestOutput data race Jun 19, 2019
@katiehockman
Copy link
Contributor

/cc @hyangah

@katiehockman katiehockman added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. and removed WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. labels Jun 19, 2019
@rsc rsc changed the title runtime/pprof/internal/profile: TestOutput data race runtime/race: external_cgo_thread passed unexpectedly in TestOutput Jun 28, 2019
@bcmills
Copy link
Member

bcmills commented Dec 4, 2020

I think #43008 is a duplicate of this issue, but I've added a bit more information there already so I'm going to dup this one to that instead.

@bcmills
Copy link
Member

bcmills commented Dec 4, 2020

Duplicate of #43008

@bcmills bcmills marked this as a duplicate of #43008 Dec 4, 2020
@cuonglm cuonglm closed this as completed Dec 7, 2020
@golang golang locked and limited conversation to collaborators Dec 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests

4 participants