Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime/race: external_cgo_thread passed unexpectedly in TestOutput #32653

Open
cuonglm opened this issue Jun 17, 2019 · 3 comments

Comments

@cuonglm
Copy link
Contributor

commented Jun 17, 2019

https://storage.googleapis.com/go-build-log/63849344/linux-amd64-race_657c252c.log

Output extracted from test log:

--- FAIL: TestOutput (9.68s)
    output_test.go:76: failed test case external_cgo_thread, expect:
        ==================
        WARNING: DATA RACE
        Read at 0x[0-9,a-f]+ by main goroutine:
          main\.main\(\)
              .*/main\.go:34 \+0x[0-9,a-f]+
        
        Previous write at 0x[0-9,a-f]+ by goroutine [0-9]:
          main\.goCallback\(\)
              .*/main\.go:27 \+0x[0-9,a-f]+
          main._cgoexpwrap_[0-9a-z]+_goCallback\(\)
              .*_cgo_gotypes\.go:[0-9]+ \+0x[0-9,a-f]+
        
        Goroutine [0-9] \(running\) created at:
          runtime\.newextram\(\)
              .*/runtime/proc.go:[0-9]+ \+0x[0-9,a-f]+
        ==================
        got:
@katiehockman

This comment has been minimized.

Copy link
Contributor

commented Jun 18, 2019

Can you please provide more information on what action we should be taking with this issue report? It looks like this is just from a trybots run in https://go-review.googlesource.com/c/go/+/182561, and that the builders are passing for linux-amd64-race right now.

@cuonglm

This comment has been minimized.

Copy link
Contributor Author

commented Jun 19, 2019

@katiehockman it's a data race, so it can happen this time but not that time.

@katiehockman katiehockman changed the title runtime: pprof test data race runtime/pprof/internal/profile: TestOutput data race Jun 19, 2019

@katiehockman

This comment has been minimized.

Copy link
Contributor

commented Jun 19, 2019

/cc @hyangah

@rsc rsc changed the title runtime/pprof/internal/profile: TestOutput data race runtime/race: external_cgo_thread passed unexpectedly in TestOutput Jun 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.