Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: ServerCapabilities.RenameProvider should be interface #32710

Open
suzmue opened this issue Jun 20, 2019 · 2 comments

Comments

Projects
None yet
3 participants
@suzmue
Copy link
Contributor

commented Jun 20, 2019

ServerCapabilities.RenameProvider needs to be interface in the generated struct.

The server may need to return either a boolean or RenameOptions to the client, since it may only send RenameOptions if the client specifies prepareSupport.

Re: Issue #32703

@gopherbot gopherbot added the gopls label Jun 20, 2019

@suzmue suzmue changed the title internal/lsp/protocol: ServerCapabilities.RenameProvider should be interface x/tools/internal/lsp/protocol: ServerCapabilities.RenameProvider should be interface Jun 20, 2019

@gopherbot gopherbot added this to the Unreleased milestone Jun 20, 2019

@suzmue

This comment has been minimized.

Copy link
Contributor Author

commented Jun 20, 2019

@pjweinb : Could we make this change in the protocol generator?

@pjweinb

This comment has been minimized.

Copy link
Contributor

commented Jun 21, 2019

@stamblerre stamblerre changed the title x/tools/internal/lsp/protocol: ServerCapabilities.RenameProvider should be interface x/tools/gopls: ServerCapabilities.RenameProvider should be interface Jul 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.