Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: ServerCapabilities.RenameProvider should be interface #32710

Closed
suzmue opened this issue Jun 20, 2019 · 3 comments
Closed

x/tools/gopls: ServerCapabilities.RenameProvider should be interface #32710

suzmue opened this issue Jun 20, 2019 · 3 comments
Labels
Milestone

Comments

@suzmue
Copy link
Contributor

@suzmue suzmue commented Jun 20, 2019

ServerCapabilities.RenameProvider needs to be interface in the generated struct.

The server may need to return either a boolean or RenameOptions to the client, since it may only send RenameOptions if the client specifies prepareSupport.

Re: Issue #32703

@gopherbot gopherbot added the gopls label Jun 20, 2019
@suzmue suzmue changed the title internal/lsp/protocol: ServerCapabilities.RenameProvider should be interface x/tools/internal/lsp/protocol: ServerCapabilities.RenameProvider should be interface Jun 20, 2019
@gopherbot gopherbot added this to the Unreleased milestone Jun 20, 2019
@suzmue

This comment has been minimized.

Copy link
Contributor Author

@suzmue suzmue commented Jun 20, 2019

@pjweinb : Could we make this change in the protocol generator?

@pjweinb

This comment has been minimized.

Copy link
Contributor

@pjweinb pjweinb commented Jun 21, 2019

@stamblerre stamblerre changed the title x/tools/internal/lsp/protocol: ServerCapabilities.RenameProvider should be interface x/tools/gopls: ServerCapabilities.RenameProvider should be interface Jul 2, 2019
@gopherbot gopherbot added the Tools label Sep 12, 2019
@stamblerre

This comment has been minimized.

Copy link
Contributor

@stamblerre stamblerre commented Nov 4, 2019

This is done as of CL 194177.

@stamblerre stamblerre closed this Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.