Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
x/website: hovering over links on redesigned website can break scrolling #32739
What did you do?
What did you expect to see?
I expected the website to scroll.
What did you see instead?
Instead of scrolling the website, I am scrolling… the link.
@dominikh super weird
The extent to which the styling has been changed on that page is text color.
I’m unable to repro using Firefox 67.0.4 (64-bit) on macOS Mojave 10.14.5 (18F132) but I’m using a trackpad to scroll and not a mouse wheel, which may be the issue? It would be very odd if so.
This requires a bit more investigation. I'm assuming you're on linux? This also never occurs on https://golang.org?
Changed in comparison to what? https://golang.org/doc/ and https://tip.golang.org/doc/ seem significantly different to me. The diff (ignoring case changes and whitespace) between https://golang.org/lib/godoc/style.css and https://tip.golang.org/lib/godoc/style.css is almost a thousand lines.
As far as reproducing it is concerned: I know several people who cannot reproduce it, but @mvdan can. I am on Linux, I don't know anything about his setup, but I'm sure he'll chime in.
That is correct.
Since I can reproduce the issue reliably, I'll try and see if I can diagnose it further.
Thanks for doing the investigation and analysis.
My guess is that it's related to the fonts available on your system, etc.
It's possible to reproduce on macOS/Chrome by manually forcing a smaller height to the h3 element, e.g.,
Well, yes, that surely is a factor, but not really an explanation for why the h3 isn't automatically sized to contain its children. It doesn't have any size forced upon it by the stylesheet as far as I could see and should thus be as large as its children.
Edit: the tl;dr as to why this happens is that line-height is complex, and CSS is utterly screwed. On a more constructive note, there should be no reason to have