Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: cmd definition tests are flaky #32794

Closed
stamblerre opened this issue Jun 26, 2019 · 1 comment
Closed

x/tools/gopls: cmd definition tests are flaky #32794

stamblerre opened this issue Jun 26, 2019 · 1 comment

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Jun 26, 2019

The gopls cmd defintion tests tend to be flaky/inconsistent in some way.
To reproduce, run go test ./internal/lsp/cmd -run=TestDefinitionHelpExample -v -count=2. There should be unexpected errors in the logs.
They have been temporarily disabled by https://golang.org/cl/183628, but they should be fixed and re-enabled.

@gopherbot gopherbot added this to the Unreleased milestone Jun 26, 2019
@gopherbot gopherbot added the gopls label Jun 26, 2019
@dmitshur dmitshur added the Testing label Jun 27, 2019
@gopherbot gopherbot added the Tools label Sep 12, 2019
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Nov 1, 2019

Change https://golang.org/cl/204818 mentions this issue: internal/lsp/cmd: re-enable the definition cmd tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.