Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: TestScript/mod_concurrent flake on aix-ppc64 builder #32817

Open
bcmills opened this issue Jun 27, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@bcmills
Copy link
Member

commented Jun 27, 2019

From https://build.golang.org/log/f268986231f8f43781dacb0f5fe56772143ca24b (on aix-ppc64):

go test proxy running at GOPROXY=http://127.0.0.1:34444/mod
--- FAIL: TestScript (0.00s)
    --- FAIL: TestScript/mod_concurrent (1.51s)
        script_test.go:191: 
            # Concurrent builds should succeed, even if they need to download modules. (0.924s)
            > go build ./x &
            > go build ./y
            [stderr]
            go: can't lock version list lockfile: Lock $WORK/gopath/pkg/mod/cache/download/golang.org/x/text/@v/list.lock: deadlock condition if locked
            [exit status 1 (core dumped)]
            FAIL: testdata/script/mod_concurrent.txt:5: unexpected command failure
            
FAIL
FAIL	cmd/go	106.612s

I suspect that this is actually an AIX kernel bug (namely, being overly pessimistic about the deadlock properties of file locks in a multi-threaded program), but perhaps we should consider some sort of workaround.

CC @Helflym @jayconrod

@Helflym

This comment has been minimized.

Copy link
Contributor

commented Jun 28, 2019

Yeah, I'm already aware of this bug. I know that it can happen sometimes on AIX 7.2 TL0.
However, I think that's the first time I'm seeing it on AIX 7.2 TL2 (the AIX version on the builder)...

I've made a old workaround a few months back (cf CL 152718). It could be updated and merged if we need a quick workaround while we're trying to find a true fix (if any).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.