Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: frequent "expected full AST […], returned trimmed" failures in builders #32832

Open
bcmills opened this issue Jun 28, 2019 · 2 comments

Comments

Projects
None yet
4 participants
@bcmills
Copy link
Member

commented Jun 28, 2019

I've been looking through flakes on the build dashboard, and noticed a pattern in the x/tools/internal/lsp tests. They seem to fail frequently with error messages of the form expected full AST for file:///tmp/workdir/tmp/[…].go, returned trimmed.

Examples:
https://build.golang.org/log/035d6f57a677b538aa7bcbab8e4d959d225896b3
https://build.golang.org/log/bd47b4f273b8fba6536cbb47257a2340c0575bad
https://build.golang.org/log/035d6f57a677b538aa7bcbab8e4d959d225896b3
https://build.golang.org/log/2d45e4b10c7e990d922b9606b99db59c4d10635c
https://build.golang.org/log/008b9f9c6839ab16253155c23b5f22f5df9a2222

CC @stamblerre @ianthehat

@bcmills bcmills added this to the Unreleased milestone Jun 28, 2019

@gopherbot gopherbot added the gopls label Jun 28, 2019

@bcmills

This comment has been minimized.

Copy link
Member Author

commented Jun 28, 2019

It's not clear to me whether this one is related or not: a no AST for rather than expected full AST.
https://build.golang.org/log/13d5da81654a025a3bf86d38b616d7936a0788f2

@stamblerre

This comment has been minimized.

Copy link
Contributor

commented Jun 28, 2019

There are some race conditions in gopls but we are working on a significant rewrite, so hopefully those flakes will go away once those are in.

@stamblerre stamblerre changed the title x/tools/internal/lsp: frequent "expected full AST […], returned trimmed" failures in builders x/tools/gopls: frequent "expected full AST […], returned trimmed" failures in builders Jul 2, 2019

@dmitshur dmitshur added the Testing label Jul 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.