Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/go/packages: panic in testParseFileModifyAST #32833

Open
bcmills opened this issue Jun 28, 2019 · 1 comment
Open

x/tools/go/packages: panic in testParseFileModifyAST #32833

bcmills opened this issue Jun 28, 2019 · 1 comment

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Jun 28, 2019

Observed in https://build.golang.org/log/269df758e38c6dcc180de71777773231b6f98014 (on windows-amd64-2016):

panic: runtime error: index out of range [recovered]
	panic: runtime error: index out of range

goroutine 512 [running]:
testing.tRunner.func1(0xc0001bab00)
	C:/workdir/go/src/testing/testing.go:830 +0x399
panic(0x6e5800, 0x9959e0)
	C:/workdir/go/src/runtime/panic.go:522 +0x1c3
golang.org/x/tools/go/packages_test.testParseFileModifyAST(0xc0001bab00, 0x7a5740, 0x9bbf10)
	C:/workdir/gopath/src/golang.org/x/tools/go/packages/packages_test.go:852 +0x4b9
golang.org/x/tools/go/packages/packagestest.TestAll.func1(0xc0001bab00)
	C:/workdir/gopath/src/golang.org/x/tools/go/packages/packagestest/export.go:101 +0x6f
testing.tRunner(0xc0001bab00, 0xc000047e60)
	C:/workdir/go/src/testing/testing.go:865 +0xc7
created by testing.(*T).Run
	C:/workdir/go/src/testing/testing.go:916 +0x361
FAIL	golang.org/x/tools/go/packages	17.895s

It's not obvious to me whether this is a secondary symptom of the race reported in #31749 or an unrelated bug.

CC @matloob @ianthehat

@bcmills bcmills changed the title golang.org/x/tools/go/packages: panic in testParseFileModifyAST x/tools/go/packages: panic in testParseFileModifyAST Jun 28, 2019
@gopherbot gopherbot added this to the Unreleased milestone Jun 28, 2019
@gopherbot gopherbot added the Tools label Sep 12, 2019
@matloob

This comment has been minimized.

Copy link
Contributor

@matloob matloob commented Oct 30, 2019

Have we been able to reproduce this? Does this only happen on Windows?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.