Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/go/packages: panic in testParseFileModifyAST #32833

bcmills opened this issue Jun 28, 2019 · 1 comment

x/tools/go/packages: panic in testParseFileModifyAST #32833

bcmills opened this issue Jun 28, 2019 · 1 comment


Copy link

@bcmills bcmills commented Jun 28, 2019

Observed in (on windows-amd64-2016):

panic: runtime error: index out of range [recovered]
	panic: runtime error: index out of range

goroutine 512 [running]:
	C:/workdir/go/src/testing/testing.go:830 +0x399
panic(0x6e5800, 0x9959e0)
	C:/workdir/go/src/runtime/panic.go:522 +0x1c3, 0x7a5740, 0x9bbf10)
	C:/workdir/gopath/src/ +0x4b9
	C:/workdir/gopath/src/ +0x6f
testing.tRunner(0xc0001bab00, 0xc000047e60)
	C:/workdir/go/src/testing/testing.go:865 +0xc7
created by testing.(*T).Run
	C:/workdir/go/src/testing/testing.go:916 +0x361
FAIL	17.895s

It's not obvious to me whether this is a secondary symptom of the race reported in #31749 or an unrelated bug.

CC @matloob @ianthehat

@bcmills bcmills changed the title panic in testParseFileModifyAST x/tools/go/packages: panic in testParseFileModifyAST Jun 28, 2019
@gopherbot gopherbot added this to the Unreleased milestone Jun 28, 2019
Copy link

@matloob matloob commented Oct 30, 2019

Have we been able to reproduce this? Does this only happen on Windows?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants