Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/present: presentation note window not rendering correctly #32902

Closed
johanbrandhorst opened this issue Jul 2, 2019 · 1 comment
Closed

x/tools/present: presentation note window not rendering correctly #32902

johanbrandhorst opened this issue Jul 2, 2019 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@johanbrandhorst
Copy link
Member

johanbrandhorst commented Jul 2, 2019 •
edited
Loading

What version of Go are you using (go version)?

$ go version
go version go1.12.6 linux/amd64

Does this issue reproduce with the latest release?

Yes

What did you do?

I used the presenter notes feature of the present tool.

What did you expect to see?

I expected a window with an iframe of the presentation and the presenter notes.

What did you see instead?

A small iframe in the corner and a console warning:

image

notes.js:57 Uncaught ReferenceError: getDestSlideKey is not defined
    at initNotes (notes.js:57)
    at toggleNotesWindow (notes.js:26)
    at HTMLDocument.handleBodyKeyDown (slides.js:406)

It seems golang/tools@a101b04 introduced a few incorrect references.

I intend to submit a fix for this.
@gopherbot gopherbot added this to the Unreleased milestone Jul 2, 2019
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/184737 mentions this issue: cmd/present: correct function reference.

@bcmills bcmills mentioned this issue Jul 2, 2019
Closed
@bcmills bcmills added the NeedsFix The path to resolution is known, but the work has not been done. label Jul 2, 2019
movie-travel-code pushed a commit to movie-travel-code/tools that referenced this issue Jul 11, 2019
@johanbrandhorst
cmd/present: correct function reference.
852aad3 
A previous change introduced a new way of storing
which page should be synced with the notes, but
used the wrong function name. This corrects the
function reference.

Fixes golang/go#32902

Change-Id: Iefbb189eae12f0d53e46e6f42d3526302515cab3
Reviewed-on: https://go-review.googlesource.com/c/tools/+/184737
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
@golang golang locked and limited conversation to collaborators Jul 1, 2020
tmc pushed a commit to tmc/presentx that referenced this issue Jun 19, 2024
@johanbrandhorst
cmd/present: correct function reference.
9787c26 
A previous change introduced a new way of storing
which page should be synced with the notes, but
used the wrong function name. This corrects the
function reference.

Fixes golang/go#32902

Change-Id: Iefbb189eae12f0d53e46e6f42d3526302515cab3
Reviewed-on: https://go-review.googlesource.com/c/tools/+/184737
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@bcmills @johanbrandhorst @gopherbot