Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/present: presenter notes do not work: Uncaught ReferenceError: getDestSlideKey is not defined #32904

Closed
flowchartsman opened this issue Jul 2, 2019 · 2 comments

Comments

@flowchartsman
Copy link

@flowchartsman flowchartsman commented Jul 2, 2019

What version of Go are you using (go version)?

$ go version
go1.12 darwin/amd64

Does this issue reproduce with the latest release?

Yes.

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/awalker/Library/Caches/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/awalker/go"
GOPROXY=""
GORACE=""
GOROOT="/Users/awalker/opt/go"
GOTMPDIR=""
GOTOOLDIR="/Users/awalker/opt/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/cf/y_tt0zms6nx39x08k23y5zsr0000gn/T/go-build767986455=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

The error in the issue title is displayed on the JS console when attempting to view a presentation which has notes. If I hit 'N', the window opens, but no notes are displayed.

What did you expect to see?

Notes displayed.

What did you see instead?

No notes.

Reversion to the checkout release-branch.go1.11 fixed the issue. In addition, only two references to getDestSlideKey were found in the code, but no definition could be located. Reversion or incomplete checkin, perhaps?

@gopherbot gopherbot added this to the Unreleased milestone Jul 2, 2019
@flowchartsman flowchartsman changed the title x/tools/present: Uncaught ReferenceError: getDestSlideKey is not defined x/tools/present: presenter notes do not work: Uncaught ReferenceError: getDestSlideKey is not defined Jul 2, 2019
@bcmills
Copy link
Member

@bcmills bcmills commented Jul 2, 2019

Probably a side-effect of CL 178659 for #24688.

CC @andybons @danicat

@bcmills
Copy link
Member

@bcmills bcmills commented Jul 2, 2019

Duplicate of #32902

@bcmills bcmills marked this as a duplicate of #32902 Jul 2, 2019
@bcmills bcmills closed this Jul 2, 2019
@golang golang locked and limited conversation to collaborators Jul 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.