Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: TestTCPServer flaky on macOS 10.12 builders #32919

Closed
bcmills opened this issue Jul 3, 2019 · 12 comments
Closed

net: TestTCPServer flaky on macOS 10.12 builders #32919

bcmills opened this issue Jul 3, 2019 · 12 comments

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Jul 3, 2019

From https://build.golang.org/log/19f0ac1d66a927076b256862638641e261489304 on the darwin-amd64-race builder:

--- FAIL: TestTCPServer (10.01s)
    server_test.go:60: skipping tcp :0<-127.0.0.1 test
    server_test.go:60: skipping tcp 0.0.0.0:0<-127.0.0.1 test
    server_test.go:60: skipping tcp [::ffff:0.0.0.0]:0<-127.0.0.1 test
    server_test.go:60: skipping tcp [::]:0<-::1 test
    server_test.go:60: skipping tcp :0<-::1 test
    server_test.go:60: skipping tcp 0.0.0.0:0<-::1 test
    server_test.go:60: skipping tcp [::ffff:0.0.0.0]:0<-::1 test
    server_test.go:60: skipping tcp [::]:0<-127.0.0.1 test
    server_test.go:60: skipping tcp :0<-127.0.0.1 test
    server_test.go:60: skipping tcp 0.0.0.0:0<-127.0.0.1 test
    server_test.go:60: skipping tcp [::ffff:0.0.0.0]:0<-127.0.0.1 test
    server_test.go:60: skipping tcp [::]:0<-::1 test
    server_test.go:60: skipping tcp :0<-::1 test
    server_test.go:60: skipping tcp 0.0.0.0:0<-::1 test
    server_test.go:60: skipping tcp [::ffff:0.0.0.0]:0<-::1 test
    server_test.go:60: skipping tcp [::]:0<-127.0.0.1 test
    server_test.go:107: dial tcp [::1]:49737: i/o timeout
FAIL
FAIL	net	23.757s

CC @mikioh @ianlancetaylor

@bcmills

This comment has been minimized.

Copy link
Member Author

@bcmills bcmills commented Jul 3, 2019

Compare #32534.

@bcmills

This comment has been minimized.

Copy link
Member Author

@bcmills bcmills commented Aug 13, 2019

@bcmills

This comment has been minimized.

Copy link
Member Author

@bcmills bcmills commented Aug 29, 2019

@bcmills bcmills changed the title net: TestTCPServer flake on darwin-amd64-race net: TestTCPServer flaky on darwin-amd64-race Aug 29, 2019
@bcmills

This comment has been minimized.

Copy link
Member Author

@bcmills bcmills commented Aug 29, 2019

Seems like we have enough of these to form a pattern.

CC @mikioh @bradfitz @ianlancetaylor

@bcmills

This comment has been minimized.

Copy link
Member Author

@bcmills bcmills commented Sep 3, 2019

@bcmills bcmills changed the title net: TestTCPServer flaky on darwin-amd64-race net: TestTCPServer flaky on darwin-amd64 builders Sep 3, 2019
@bcmills

This comment has been minimized.

Copy link
Member Author

@bcmills bcmills commented Sep 27, 2019

@bcmills

This comment has been minimized.

Copy link
Member Author

@bcmills bcmills commented Oct 11, 2019

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Oct 11, 2019

It would be interesting to know whether this ever occurs on a version of Darwin later than 10.12.

@bcmills

This comment has been minimized.

Copy link
Member Author

@bcmills bcmills commented Oct 11, 2019

Looks like it hasn't so far: darwin-amd64-race is still 10.12.

@bcmills

This comment has been minimized.

Copy link
Member Author

@bcmills bcmills commented Oct 15, 2019

That suggests that this may be the same underlying issue as #22019.

@bcmills bcmills changed the title net: TestTCPServer flaky on darwin-amd64 builders net: TestTCPServer flaky on macOS 10.12 builders Oct 15, 2019
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Oct 22, 2019

Change https://golang.org/cl/202618 mentions this issue: net: ignore or skip known-flaky localhost Dial operations on macOS 10.12 builder

@gopherbot gopherbot closed this in 95544cc Oct 22, 2019
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Oct 22, 2019

Change https://golang.org/cl/202561 mentions this issue: net: convert TestTCPServer to use subtests

gopherbot pushed a commit that referenced this issue Oct 22, 2019
My fix in CL 202618 inadvertently violated an invariant in the inner
loop of TestTCPServer (namely, that len(trchs) == i). That causes a
panic when one or more of the channels is omitted due to a flake.

Instead of trying to fix up the test, let's just factor out a subtest
and skip the whole thing if the transceiver's Dial flakes out.

Updates #32919

Change-Id: Ib6f274a44194311c8c5a2faf19f586cc9eccfd4d
Reviewed-on: https://go-review.googlesource.com/c/go/+/202561
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.