Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

math/big: arm64 assembly code for shlVU is incorrect [1.12 backport] #32940

Open
gopherbot opened this issue Jul 4, 2019 · 5 comments

Comments

Projects
None yet
5 participants
@gopherbot
Copy link

commented Jul 4, 2019

@erifan requested issue #31084 to be considered for backport to the next 1.13 minor release.

@gopherbot Please open backport issue to 1.13

@dmitshur

This comment was marked as outdated.

Copy link
Member

commented Jul 5, 2019

No need for a cherry-pick for 1.13, the fix is already on master branch and will be a part of Go 1.13 when that's released.

See #31084 (comment) for context.

@dmitshur

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

Targeting 1.12 and reopening for consideration per #31084 (comment).

@dmitshur dmitshur reopened this Jul 8, 2019

@dmitshur dmitshur added this to the Go1.12.7 milestone Jul 8, 2019

@dmitshur dmitshur changed the title math/big: arm64 assembly code for shlVU is incorrect [1.13 backport] math/big: arm64 assembly code for shlVU is incorrect [1.12 backport] Jul 8, 2019

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

commented Jul 8, 2019

I think it's fine to backport https://golang.org/cl/169780 to the 1.12 branch.

I don't think it's a release blocker, as the problem is not new.

@toothrot toothrot modified the milestones: Go1.12.7, Go1.12.8 Jul 8, 2019

@toothrot

This comment has been minimized.

Copy link
Contributor

commented Jul 8, 2019

Moving to Go1.12.8 because there is no backport CL ready in time for this release.

@gopherbot

This comment has been minimized.

Copy link
Author

commented Jul 9, 2019

Change https://golang.org/cl/185041 mentions this issue: [release-branch.go1.12] math/big: fix the bug in assembly implementation of shlVU on arm64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.