Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/playground: Format button produces a spurious 'invalid module version' error for commit hashes in go.mod #32980

Open
bcmills opened this issue Jul 8, 2019 · 1 comment
Labels
Milestone

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Jul 8, 2019

go subcommands such as go mod tidy, go test, and go build automatically resolve invalid versions found in the go.mod file to valid ones.

However, the Playground's Format button does not; instead, it emits an error message like:

go.mod:5: invalid module version "1f3472d942ba824034fb77cab6a6cfc1bc8a2c3c": version must be of the form v1.2.3

This is probably due to calling out to a golang.org/x/mod library instead of running the go command directly. (See also #32955 (comment) and #32614.)

CC @toothrot @dmitshur @ysmolsky

@gopherbot gopherbot added this to the Unreleased milestone Jul 8, 2019
@bcmills

This comment has been minimized.

Copy link
Member Author

@bcmills bcmills commented Jul 8, 2019

Example: https://play.golang.org/p/yMyG925ovLb

Format produces an error, but Run runs the binary without error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.