Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
x/tools/gopls: handle 404-ing links in documentLink #32994
HI @stamblerre! I can work on this issue especially as I am working now on #32339. The question is: is it really necessary to send HTTP request for each link in the file? I can see at least two possible issues here:
At first right now with implemented #32339 the documentLinks sometimes takes seconds to return the list of links. This is request for file with about 900 lines of code:
The second issue is that I am not sure that developers expect network usage from language server especially during working with mobile internet. Making a bunch of HTTP calls on each documentLinks request can cause not only clogging of internet connection but also increased bills if you are working on mobile internet. I am not sure that scenario of usage mobile internet is wide and probably needs discussion.
Thanks for sharing. I think this issue is probably not very pressing, and I just wanted to open it to note that this has been mentioned, but I think we can close it for now. I'm certain this will come up on the future, and we can figure out a way to handle it then.