Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/website: remove G+ Community links #33049

Closed
Prithvipal opened this issue Jul 11, 2019 · 3 comments
Closed

x/website: remove G+ Community links #33049

Prithvipal opened this issue Jul 11, 2019 · 3 comments

Comments

@Prithvipal
Copy link

@Prithvipal Prithvipal commented Jul 11, 2019

Google plus is no longer available so G+ Community link: https://golang.org/help/#pluscom should be removed from the Help page. Clicking on this link shows below message:

Google+ is no longer available for consumer (personal) and brand accounts

@gopherbot gopherbot added this to the Unreleased milestone Jul 11, 2019
@Prithvipal Prithvipal changed the title x/website: Remote G+ Community links x/website: Remove G+ Community links Jul 11, 2019
@andybons andybons added the NeedsFix label Jul 11, 2019
@andybons andybons changed the title x/website: Remove G+ Community links x/website: remove G+ Community links Jul 11, 2019
@dgryski
Copy link
Contributor

@dgryski dgryski commented Jul 11, 2019

bc27b64 didn't get ported to /x/website. Not sure if there are any other fixes that need to be migrated.

@agnivade
Copy link
Contributor

@agnivade agnivade commented Jul 11, 2019

Thanks @dgryski. The commit was made 23 days ago. x/website does not directly hold templates which are in the main repo. They are loaded dynamically. golang.org will show it when it gets redeployed. You can see that tip.golang.org shows it correctly.

I am closing the issue as the code fix has already been made. And it will appear in golang.org when it gets redeployed.

@agnivade agnivade closed this Jul 11, 2019
@andybons
Copy link
Member

@andybons andybons commented Jul 12, 2019

It will get deployed once 1.13 is released (unless someone cherry-picks the fix to the 1.12 branch). We’re still working to move all our docs into x/website so that we don’t have to do this much for such a small change.

@golang golang locked and limited conversation to collaborators Jul 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.