Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: logs wrong error message on links request #33087

Closed
litleleprikon opened this issue Jul 12, 2019 · 2 comments
Closed

x/tools/gopls: logs wrong error message on links request #33087

litleleprikon opened this issue Jul 12, 2019 · 2 comments
Labels
Milestone

Comments

@litleleprikon
Copy link

@litleleprikon litleleprikon commented Jul 12, 2019

What version of Go are you using (go version)?

$ go version
go version go1.12.6 darwin/amd64

Does this issue reproduce with the latest release?

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/esharifu/Library/Caches/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/esharifu/projects/go"
GOPROXY=""
GORACE=""
GOROOT="/usr/local/Cellar/go/1.12.6/libexec"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.12.6/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/sh/vcq1w7n1547584p7d_kh_vf00000gn/T/go-build126212972=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

Run go test -v ./internal/lsp on tools

What did you expect to see?

No error messages on documentLinks request

What did you see instead?

2019/07/12 20:54:08 Error: cannot initialize DocumentLink "fmt": <nil>
2019/07/12 20:54:08 Error: cannot initialize DocumentLink "golang.org/x/tools/internal/lsp/foo": <nil>
@gopherbot gopherbot added this to the Unreleased milestone Jul 12, 2019
@gopherbot gopherbot added the gopls label Jul 12, 2019
@litleleprikon

This comment has been minimized.

Copy link
Author

@litleleprikon litleleprikon commented Jul 12, 2019

@stamblerre I am sorry In my work for #32339 I did mistake and and placed logging for error without checking for error. I will create a fix right now

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Jul 12, 2019

Change https://golang.org/cl/186037 mentions this issue: internal/lsp: fix unnecessary error logging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.