Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/cmd/gopls: proposal: provide goimports -local equivalent config #33156

Closed
myitcv opened this issue Jul 17, 2019 · 2 comments
Closed

x/tools/cmd/gopls: proposal: provide goimports -local equivalent config #33156

myitcv opened this issue Jul 17, 2019 · 2 comments

Comments

@myitcv
Copy link
Member

@myitcv myitcv commented Jul 17, 2019

What version of Go are you using (go version)?

$ go version
go version devel +0cadf40f4c Tue Jul 16 22:31:35 2019 +0000 linux/amd64
$ go list -m golang.org/x/tools
golang.org/x/tools v0.0.0-20190716221150-e98af2309876
$ go list -m golang.org/x/tools/gopls
golang.org/x/tools/gopls v0.1.4-0.20190716221150-e98af2309876

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE="on"
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/myitcv/.cache/go-build"
GOENV="/home/myitcv/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/myitcv/gostuff"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/home/myitcv/gos"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/home/myitcv/gos/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/myitcv/gostuff/src/github.com/myitcv/govim/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build693164838=/tmp/go-build -gno-record-gcc-switches"

What did you do?

Raised originally via govim/govim#385

goimports has a -local flag documented as follows:

  -local string
        put imports beginning with this string after 3rd-party packages; comma-separated list

The proposal here therefore is to provide a []string config option to allow such a list of imports to be provided via editor plugins config options.

cc @stamblerre @ianthehat

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Jul 17, 2019

Duplicate of #32049

@stamblerre stamblerre marked this as a duplicate of #32049 Jul 17, 2019
@stamblerre stamblerre closed this Jul 17, 2019
@myitcv
Copy link
Member Author

@myitcv myitcv commented Jul 18, 2019

Goodness me, no idea how I missed that other issue. Thanks

@golang golang locked and limited conversation to collaborators Jul 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.