Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/internal/imports: tests broken with go/packages on tip #33175

Closed
stamblerre opened this issue Jul 18, 2019 · 4 comments
Closed

x/tools/internal/imports: tests broken with go/packages on tip #33175

stamblerre opened this issue Jul 18, 2019 · 4 comments

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Jul 18, 2019

/cc @heschik

@gopherbot gopherbot added this to the Unreleased milestone Jul 18, 2019
@gopherbot
Copy link

@gopherbot gopherbot commented Jul 18, 2019

Change https://golang.org/cl/186838 mentions this issue: internal/imports: disable go/packages-incompatible tests

gopherbot pushed a commit to golang/tools that referenced this issue Jul 18, 2019
A recent change to the go command broke these tests. Mark them as
go/packages incompatible for now, until we have time to fix them.

Updates golang/go#33175

Change-Id: Ib4c594bd032107fb1245bfe18fc80392fbab0730
Reviewed-on: https://go-review.googlesource.com/c/tools/+/186838
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
Reviewed-by: Ian Cottrell <iancottrell@google.com>
@heschik
Copy link
Contributor

@heschik heschik commented Jul 30, 2019

@jayconrod said he's aware of other breakages to go/packages caused by the same CL (https://golang.org/cl/154100) and will look at this.

@jayconrod
Copy link
Contributor

@jayconrod jayconrod commented Jul 30, 2019

Possibly related to #33157

@gopherbot
Copy link

@gopherbot gopherbot commented Jul 31, 2019

Change https://golang.org/cl/188379 mentions this issue: x/tools/internal/imports: don't load package names for empty list

@golang golang locked and limited conversation to collaborators Jul 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.