Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cloudfns/wikiwebhook: wiki updates reporter does not report deleted pages #33187

Open
ianlancetaylor opened this issue Jul 19, 2019 · 2 comments

Comments

@ianlancetaylor
Copy link
Contributor

commented Jul 19, 2019

gopherbot reports changes to the wiki in e-mail to golang-wikichanges, which is very helpful. However, it does not report when pages are deleted. This means that when someone carelessly or maliciously deletes a page, we don't notice. This recently happened with the page Mobile.md, in revision 0615f77906f56357715932cf43f79ef2b1823c80, and then again in revision 04aa758f8beac3ab957e3e48537d263b710c1f54, of the wiki repo, but no e-mail was sent either time.

CC @andybons

@ianlancetaylor ianlancetaylor added this to the Unreleased milestone Jul 19, 2019
@gopherbot gopherbot added the Builders label Jul 19, 2019
@andybons

This comment has been minimized.

Copy link
Member

commented Jul 19, 2019

Currently the only events we get from GitHub are created and edited so we'd have to write our own loop to check this.

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor Author

commented Jul 19, 2019

Well that is just absurd.

@andybons andybons changed the title x/build/cmd/gopherbot: wiki updates reporter does not report deleted pages x/build/cloudfns/wikiwebhook: wiki updates reporter does not report deleted pages Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.