Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
encoding/asn1: valid GeneralizedTime with UTC offset of +0000 not parsed #33192
What version of Go are you using (
Yeah, the patch for #15842 just makes it so
The problem here is that when
My patch for #15842 has the purpose of enabling the parsing of fractional digits in GeneralizedTime (From my understanding of X.690, p. 20, fractional digits are allowed in GeneralizedTime, but not in UTCTime).
This issue (33192), though, is related to UTCTime, not GeneralizedTime. (So the patch for #15842 won't fix this issue already for the reason that a different function is called for parsing).
the output will contain the line
I wonder if the
One approach would be to make asn1.go:parseUTCTime conservatively accept a
Since parseUTCTime already accepts non-standard time differentials like +0200, fixing the equality-test for
For completeness, please also see the fix for #19890, which could complement a fix for this issue, addressing the marshaling side.