Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: support window/showMessage request #33198

Closed
jadekler opened this issue Jul 19, 2019 · 4 comments
Closed

x/tools/gopls: support window/showMessage request #33198

jadekler opened this issue Jul 19, 2019 · 4 comments
Labels
Milestone

Comments

@jadekler
Copy link
Contributor

@jadekler jadekler commented Jul 19, 2019

Sometimes gopls takes a few seconds to process what's happening. I don't have a concrete example - it just seems to sometimes take 100ms to do something, and other times it takes 5s.

It would be great if gopls would fail fast with an error message that popped up in vscode, and that I could adjust what that threshold should be.

Having fast feedback is almost always more important to me than eventual correctness.

@gopherbot gopherbot added the gopls label Jul 19, 2019
@stamblerre

This comment has been minimized.

Copy link
Contributor

@stamblerre stamblerre commented Jul 21, 2019

What features are you finding that take 5s? We are working on correcting this behavior, so ultimately it shouldn't be necessary. The only way for gopls to send error messages that pop up in VSCode is via the diagnostics messages (the same way that gopls shows errors in your code).

@stamblerre stamblerre changed the title gopls: fail fast x/tools/gopls: fail fast Jul 21, 2019
@gopherbot gopherbot added this to the Unreleased milestone Jul 21, 2019
@jadekler

This comment has been minimized.

Copy link
Contributor Author

@jadekler jadekler commented Jul 22, 2019

What features are you finding that take 5s?

I'm afraid I'm a bit unintelligent about gopls vis-a-vis separating "it works" into features heh. So, not sure. General use, though, I suppose?

The only way for gopls to send error messages that pop up in VSCode is via the diagnostics messages (the same way that gopls shows errors in your code).

Ah, gotcha. That seems limiting, so maybe this request is not feasible?

We are working on correcting this behavior, so ultimately it shouldn't be necessary.

Gotcha. Is there a different issue I should track, and close this one?

@stamblerre

This comment has been minimized.

Copy link
Contributor

@stamblerre stamblerre commented Jul 22, 2019

We've heard reports of imports taking too long, which is why I ask. I guess we could also make use of the https://microsoft.github.io/language-server-protocol/specification#window_showMessage LSP request, so I guess we could change this issue to be that.

@stamblerre stamblerre changed the title x/tools/gopls: fail fast x/tools/gopls: implement window/showMessage request Jul 22, 2019
@stamblerre stamblerre changed the title x/tools/gopls: implement window/showMessage request x/tools/gopls: support window/showMessage request Aug 6, 2019
@stamblerre

This comment has been minimized.

Copy link
Contributor

@stamblerre stamblerre commented Aug 6, 2019

This issue is really a duplicate of #31668. Closing in favor of that issue.

@stamblerre stamblerre closed this Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.