Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/website: Go latest release version info oh home page #33212

Closed
nurali-techie opened this issue Jul 22, 2019 · 5 comments
Closed

x/website: Go latest release version info oh home page #33212

nurali-techie opened this issue Jul 22, 2019 · 5 comments
Milestone

Comments

@nurali-techie
Copy link

@nurali-techie nurali-techie commented Jul 22, 2019

What version of Go are you using (go version)?

NA

Does this issue reproduce with the latest release?

NA

What operating system and processor architecture are you using (go env)?

NA

What did you do?

Visit home page https://golang.org/

What did you expect to see?

This is new feature. As user of Go language, it would be great if I can see latest release version of Go on home page.

The Usecase is, as Go lang user, I visit home page to see latest updates like new blog, new go release etc. If I can see latest release version of Go then I can instantly download and start using it.

I just expect Go release number somewhere on home page.

What did you see instead?

Currently, I need to first visit Home page https://golang.org/ and then click "Download Go" which takes me to https://golang.org/dl/ where I can see latest release as well as download link.

@gopherbot gopherbot added this to the Unreleased milestone Jul 22, 2019
@ALTree
Copy link
Member

@ALTree ALTree commented Jul 22, 2019

Thanks for the request.

This is essentially a dup of #33083 (show current Go version next to download button on homepage). Andybons is working on this, so I think we can close this issue in favour of the older one. Feel free to subscribe to that thread for updates.

@ALTree ALTree closed this Jul 22, 2019
@agnivade
Copy link
Contributor

@agnivade agnivade commented Jul 22, 2019

Sorry for the confusion here. OP had opened #33145 which I closed citing the same reason. And I asked him to open a new issue for this.

As far as I understand, #33083 is just about showing the existing string which was shown at the footer to be shown next to the download page. But that string just shows the version with which x/website is being built.

OP wants the latest released Go version to be displayed on the home page. I understand both are eventually equivalent, but not exactly same. If that is what @andybons meant in #33083, then we can close this.

So just to be clear, I will reopen this and leave it to Andy for a final call.

Apologies for the to-and-fro.

@agnivade agnivade reopened this Jul 22, 2019
@ALTree
Copy link
Member

@ALTree ALTree commented Jul 22, 2019

Wait, I don't get it. If we end up showing something on the DOWNLOAD button, it'll be the latest released version, right? Which is what the OP is asking here. So #33083 will solve the issues this OP has.

I don't think the version near the download button will show the version the website was built with (it wouldn't make much sense for that information to be on the download button).

Also the OP in that old issues wrote:

I used to check the website to see if a new version was released

it seems he's talking about the latest released version, I don't think he cares about the version the website was build for. So my understanding is that 1) OP here and OP in #33083 are asking exactly for the same thing 2) andybons work will fix #33083 (and this one) and satisfy both OPs

@nurali-techie
Copy link
Author

@nurali-techie nurali-techie commented Jul 22, 2019

@ALTree yes, I don't care about the version the website was build for. I am requesting to show Go latest release version on home page. (anywhere on homepage).

@agnivade
Copy link
Contributor

@agnivade agnivade commented Jul 22, 2019

@ALTree Yeah, I guess you are right. I just wanted to clarify that the initial assumption of OP in #33083 was wrong. It's not just a matter of showing the exact same string in a different location now. We will be showing something completely different.

I guess we can close this since the end result of #33083 is the right one in any case.

@nurali-techie - My apologies for asking you to open a new issue. It seems #33083 is what you should be tracking.

@agnivade agnivade closed this Jul 22, 2019
@golang golang locked and limited conversation to collaborators Jul 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.