Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: optimize http2 in readPreface phase #33268

Closed
detailyang opened this issue Jul 24, 2019 · 5 comments
Closed

net/http: optimize http2 in readPreface phase #33268

detailyang opened this issue Jul 24, 2019 · 5 comments

Comments

@detailyang
Copy link

@detailyang detailyang commented Jul 24, 2019

No description provided.

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Jul 24, 2019

Change https://golang.org/cl/187457 mentions this issue: x/net/http2: zero allocate in readPreface

@ALTree ALTree changed the title perf: optimize http2 in readPreface phase net/http: optimize http2 in readPreface phase Jul 24, 2019
@ALTree ALTree added the Performance label Jul 24, 2019
@ALTree ALTree added this to the Unplanned milestone Jul 24, 2019
@av86743

This comment has been minimized.

Copy link

@av86743 av86743 commented Jul 24, 2019

That's some negation:

		} else if string(buf[0:8]) != "PRI * HT" &&
			string(buf[8:16]) != "TP/2.0\r\n" &&
			string(buf[16:24]) != "\r\nSM\r\n\r\n" {
@FiloSottile

This comment has been minimized.

Copy link
Member

@FiloSottile FiloSottile commented Jul 30, 2019

@av86743 Please use Gerrit for code review, so authors and future reviewers can track comments associated with revisions.

@av86743

This comment has been minimized.

Copy link

@av86743 av86743 commented Jul 30, 2019

@av86743 Please use Gerrit for code review, so authors and future reviewers can track comments associated with revisions.

Why would I?

@bradfitz

This comment has been minimized.

Copy link
Contributor

@bradfitz bradfitz commented Sep 23, 2019

On https://go-review.googlesource.com/c/net/+/187457 I said:

Sorry, this isn't something that happens enough to be worth optimizing, especially not at this readability/complexity cost.

@bradfitz bradfitz closed this Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.