Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasm: emit producer custom section #33295

Open
xtuc opened this issue Jul 26, 2019 · 4 comments

Comments

@xtuc
Copy link

commented Jul 26, 2019

What version of Go are you using (go version)?

$ go version
go version devel +1c45dca365 Mon Mar 4 14:21:23 2019 -0800 linux/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

GOHOSTARCH="amd64"
GOHOSTOS="linux"

go env Output
$ go env

What did you do?

Build with GOOS=js GOARCH=wasm.

What did you expect to see?

A wasm producers custom section: https://github.com/WebAssembly/tool-conventions/blob/master/ProducersSection.md with Golang's compiler and its version (or the git hash).

What did you see instead?

Not present.

@agnivade

This comment has been minimized.

Copy link
Member

commented Jul 26, 2019

@neelance - thoughts ?

We already use the custom section for recording the buildid.

@agnivade agnivade added the Arch-Wasm label Jul 26, 2019

@neelance

This comment has been minimized.

Copy link
Member

commented Jul 29, 2019

Sure, we can add this. Sounds useful. Maybe language set to Go and processed-by set to gc?

@agnivade

This comment has been minimized.

Copy link
Member

commented Jul 30, 2019

SGTM.

@cherrymui

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2019

processed-by set to gc?

For DWARF, we set DW_AT_producer to "Go cmd/compile <version>". Maybe we can consider doing the same.

@neelance neelance self-assigned this Aug 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.