Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
runtime: use PAGE_NOACCESS in sysReseve #33327
Windows version of runtime.sysReseve calls VirtualAlloc with MEM_RESERVE and PAGE_READWRITE, but it should use PAGE_NOACCESS when using MEM_RESERVE.
and in particular
Someone would have to try and see what effect this change have on memory used by Go executable before making this change. Maybe by using vmmap or rammap tools.
I am creating this issue before I forget.
I tried changing
and I run this program
and I used vmmap to compare memory map before and after the change. And I don't see any differences.
I use up to date version of Windows 10.