Skip to content

crypto/tls: client handshake regression #3339

Description

@gopherbot

by graham@gkgk.org:

## What steps will reproduce the problem?
1. _, err := tls.Dial("tcp", "irc.freenode.net:6697", nil); 
2. fmt.Println(err); 

## What is the expected output?
nil

## What do you see instead?
remote error: unexpected message

## Which compiler are you using (5g, 6g, 8g, gccgo)?
"go run"

## Which operating system are you using?
Linux x86, Ubuntu

## Which revision are you using?  (hg identify)
c8614af8523a tip 

## Please provide any additional information below.

In "release" version, this worked. In latest weekly and tip it doesn't. The
problem appeared in 11106:d620ce23ebe4, in handshake_client.go

The attached diff gets it working, as does presenting a client cert.

The problem may be that a "recordTypeHandshake" is not getting written if a
client cert is not presented.

Thread in golang-nuts:
https://groups.google.com/forum/?fromgroups#!topic/golang-nuts/04va6nnOp8I

Attachments:

  1. handshake_client.diff (746 bytes)

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions