Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/playground: use same new visual design as golang.org #33414

Open
lucacasonato opened this issue Aug 1, 2019 · 8 comments
Open

x/playground: use same new visual design as golang.org #33414

lucacasonato opened this issue Aug 1, 2019 · 8 comments
Labels
Milestone

Comments

@lucacasonato
Copy link

@lucacasonato lucacasonato commented Aug 1, 2019

https://play.golang.org does not currently use the same updated visual design as https://golang.org.

I have a PR that updates the ui to match: https://go-review.googlesource.com/c/playground/+/188557

@gopherbot gopherbot added this to the Unreleased milestone Aug 1, 2019
@lucacasonato lucacasonato changed the title x/playground: use same new design as golang.org x/playground: use same new visual design as golang.org Aug 1, 2019
@agnivade

This comment has been minimized.

Copy link
Contributor

@agnivade agnivade commented Aug 2, 2019

@andybons

This comment has been minimized.

Copy link
Member

@andybons andybons commented Aug 2, 2019

@lucacasonato Thanks for the PR. We have mocks from our designers that I’m happy to share with you if you’d like to take it on.

@andybons andybons added the NeedsFix label Aug 2, 2019
@lucacasonato

This comment has been minimized.

Copy link
Author

@lucacasonato lucacasonato commented Aug 2, 2019

That would be perfect. I would love to take this on.

@slrz

This comment has been minimized.

Copy link

@slrz slrz commented Aug 3, 2019

Abandoning the playground's soothing yellow background is not really an option, right?

@lucacasonato

This comment has been minimized.

Copy link
Author

@lucacasonato lucacasonato commented Aug 3, 2019

Well... Times change 😋

@andybons

This comment has been minimized.

Copy link
Member

@andybons andybons commented Aug 4, 2019

@lucacasonato I will follow up with you Monday. I assume the email on your profile is the best one?

@lucacasonato

This comment has been minimized.

Copy link
Author

@lucacasonato lucacasonato commented Aug 4, 2019

Sounds good. Just send it to luca.casonato@antipy.com

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Sep 10, 2019

Change https://golang.org/cl/188557 mentions this issue: x/playground: update design to match golang.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.