Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: TestScript/mod_invalid_version failing as of CL 188817 #33474

Closed
bcmills opened this issue Aug 5, 2019 · 2 comments
Closed

cmd/go: TestScript/mod_invalid_version failing as of CL 188817 #33474

bcmills opened this issue Aug 5, 2019 · 2 comments
Assignees
Milestone

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Aug 5, 2019

The linux-amd64-longtest builder started failing at CL 188817.

An error that was previously surfaced up to go get is now reported at a different point in the stack, which changes the error message reported to the user. The new error message is arguably more helpful, so we should update the test to lock it in place. I'll make that change now.

CC @dneil @jba @jayconrod @rsc

@bcmills bcmills added this to the Go1.13 milestone Aug 5, 2019
@bcmills bcmills self-assigned this Aug 5, 2019
@bcmills

This comment has been minimized.

Copy link
Member Author

@bcmills bcmills commented Aug 5, 2019

(More generally, this reveals that there are a lot of calls to os.IsNotExist within cmd/go — we should probably replace them all with errors.Is at some point in the 1.14 cycle.)

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Aug 5, 2019

Change https://golang.org/cl/188977 mentions this issue: cmd/go: adjust expected error message in TestScript/mod_invalid_version

@gopherbot gopherbot closed this in 6e11d81 Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.