Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: funccompile is reentrant #33485

Open
mdempsky opened this issue Aug 5, 2019 · 0 comments

Comments

@mdempsky
Copy link
Member

commented Aug 5, 2019

There's an awkward reentrancy issue with funccompile: funccompile calls compile, which calls dtypesym, which calls geneq/genhash/genwrapper, which call back into funccompile.

I don't think this is causing any problems today, but I was trying to work on #17728, and it led to some confusing issues due to SSA cache corruption.

It would probably be better if generated ASTs were pumped through the same compile workqueue that normal ASTs are compiled.

@mdempsky mdempsky added this to the Unplanned milestone Aug 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.