Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: separate proposal review from contended decision-making #33528

rsc opened this issue Aug 7, 2019 · 2 comments

proposal: separate proposal review from contended decision-making #33528

rsc opened this issue Aug 7, 2019 · 2 comments


Copy link

rsc commented Aug 7, 2019

The proposal process aims to reach a clear answer by discussion on the GitHub issue. Nearly all the time, it does. Rarely, it does not.

The proposal review group reviews proposals weekly to help them through the process.

When a proposal does not have a clear outcome but a decision must be made, the proposal review group also works to reach consensus among themselves on the answer; that is, they decide the outcome.

Reviewing proposals and deciding contended proposals are two different activities that need not be done by exactly the same set of people. Historically there was significant overlap, and there will likely always be some overlap, but as time goes on it seems likely that we may want to formally separate the two activities.

In particular, we may want to add more reviewers, to help the process move along and scale, but still leave truly contended decisions (which are fairly rare) to a smaller group.

@rsc rsc added this to the Proposal milestone Aug 7, 2019
Copy link

Freeaqingme commented Aug 8, 2019

This sort of reminds me of the Zend Framework CR Team - Community Review Team - for the PHP framework ZF. The focus of the CR Team wasn't only to decide/arbiter on proposed functionality, but also mentor contributors to get their code in shape for the framework.

Initially, these responsibilities were carried out by the Zend team (employees) only. However, as the project grew with more and more proposals (and first time contributors), this became less feasible over time (sounds familiar? :)). Although the CR Team rarely disagreed with the Zend team, it was a good thing nonetheless (imho) that people from different backgrounds were actively (and to some extent, formally) involved in the decision making process.

The idea of the CR Team was raised by the project lead on IRC originally, and later continued on the mailing lists. After an outline of its responsibilities had been defined, an email was put forth on the mailing list for volunteers. The idea was that 5-7 people would join, and (IIRC) 7 people signed up. There wasn't much discussion about who to join, because the contributors who volunteered had been long-term contributors and FOSS oftentimes works best as a meritocracy. After the team was formed the first task of the team was to define its own scope and responsibilities.

I don't want to suggest that the way the ZF CR-Team was set up should be copied or act as a guideline. However, given that there may be some overlap in needs/ideas, I figured I might as well share some of the experiences I had with the ZF project so that perhaps we could pickup some good ideas where they do apply to the Go project.

One concrete suggestion, though, would be to not just think who should be part of this group, but also how (if at all) membership will rotate over time. I think it'd be good to define that (at least partially) upfront.

For more info on the formation of the ZF CR Team:

(full disclosure: at the time I was also one of the first members of the ZF CR Team, but haven't been involved with the ZF project for quite a while)

@ianlancetaylor ianlancetaylor added this to Incoming in Proposals (old) Feb 17, 2021
Copy link

Change mentions this issue: README: add Go architects

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
No open projects

No branches or pull requests

3 participants