Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: move signature on top of quick documention on hover #33550

Closed
inliquid opened this issue Aug 8, 2019 · 3 comments
Closed

x/tools/gopls: move signature on top of quick documention on hover #33550

inliquid opened this issue Aug 8, 2019 · 3 comments

Comments

@inliquid
Copy link

@inliquid inliquid commented Aug 8, 2019

As a result of #32561 gopls now has additional config parameter, which allows to return full docs on hover. However atm this makes it less useful as every time documentation provided has some decent amount of text, it's only possible to see the signature after scrolling to the very bottom.
изображение

Please move signature above the documentation, as it was done previously in sourcegraph's language server, bingo, and as it's in the default vscode-go config with godoc or gogetdoc.

@gopherbot gopherbot added this to the Unreleased milestone Aug 8, 2019
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Aug 8, 2019

Change https://golang.org/cl/189459 mentions this issue: internal/lsp: move documentation below signature for hover

@stamblerre

This comment has been minimized.

Copy link
Contributor

@stamblerre stamblerre commented Aug 8, 2019

I've just come to the realization that this is effectively a duplicate of #33352. I think this needs a little more thought than my quick CL indicates. Both orderings are potentially valuable, and this issue has led me think that offering configurations might be a viable approach here. I will close this issue in favor of #33352.

@inliquid

This comment has been minimized.

Copy link
Author

@inliquid inliquid commented Aug 9, 2019

Sorry I don't understand, why don't just make it in same way, as it was done in all other versions listed above, (btw, including Goland quick documentation feature), signature at the top and the rest is scrollable documentation text?
For example here is how it looks like in VS Code when turning off gopls and with simple godoc:
изображение

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.