Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
cmd/link: stack depth check too shallow [1.11 backport] #33556
… stkcheck There is real (albeit generated) code that exceeds the limit. Updates #33555 Fixes #33556 Change-Id: I668e85825d3d2a471970e869abe63f3492213cc1 Reviewed-on: https://go-review.googlesource.com/c/go/+/189697 Run-TryBot: Ian Lance Taylor <email@example.com> TryBot-Result: Gobot Gobot <firstname.lastname@example.org> Reviewed-by: Cherry Zhang <email@example.com> (cherry picked from commit 951143c) Reviewed-on: https://go-review.googlesource.com/c/go/+/189737
This backport has been accepted and merged to the release branch, so I'll update the label from CherryPickCandidate to CherryPickApproved to reflect that.
It was a serious problem and the fix was trivial.
I think we could've rejected this candidate because there was a workaround: update to Go 1.12.x. But the CL is already merged and it's not worth reverting. /cc @ianlancetaylor