cmd/link: stack depth check too shallow [1.11 backport] #33556
Closed
Labels
Milestone
Comments
Change https://golang.org/cl/189737 mentions this issue: |
gopherbot
pushed a commit
that referenced
this issue
Aug 9, 2019
… stkcheck There is real (albeit generated) code that exceeds the limit. Updates #33555 Fixes #33556 Change-Id: I668e85825d3d2a471970e869abe63f3492213cc1 Reviewed-on: https://go-review.googlesource.com/c/go/+/189697 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Cherry Zhang <cherryyz@google.com> (cherry picked from commit 951143c) Reviewed-on: https://go-review.googlesource.com/c/go/+/189737
Closed by merging 433b76f to release-branch.go1.11. |
This backport has been accepted and merged to the release branch, so I'll update the label from CherryPickCandidate to CherryPickApproved to reflect that. It was a serious problem and the fix was trivial. I think we could've rejected this candidate because there was a workaround: update to Go 1.12.x. But the CL is already merged and it's not worth reverting. /cc @ianlancetaylor |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
@ianlancetaylor requested issue #33555 to be considered for backport to the next 1.11 minor release.
The text was updated successfully, but these errors were encountered: