Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/link: stack depth check too shallow [1.12 backport] #33557

Closed
gopherbot opened this issue Aug 8, 2019 · 5 comments
Closed

cmd/link: stack depth check too shallow [1.12 backport] #33557

gopherbot opened this issue Aug 8, 2019 · 5 comments

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Aug 8, 2019

@ianlancetaylor requested issue #33555 to be considered for backport to the next 1.12 minor release.

@gopherbot Please open backport issues.

@gopherbot

This comment has been minimized.

Copy link
Author

@gopherbot gopherbot commented Aug 9, 2019

Change https://golang.org/cl/189717 mentions this issue: [release-branch.go1.12] cmd/link: increase the function call limit in stkcheck

@gopherbot

This comment has been minimized.

Copy link
Author

@gopherbot gopherbot commented Aug 9, 2019

Closed by merging 4e15604 to release-branch.go1.12.

@gopherbot gopherbot closed this Aug 9, 2019
gopherbot pushed a commit that referenced this issue Aug 9, 2019
… stkcheck

There is real (albeit generated) code that exceeds the limit.

Updates #33555
Fixes #33557

Change-Id: I668e85825d3d2a471970e869abe63f3492213cc1
Reviewed-on: https://go-review.googlesource.com/c/go/+/189697
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
(cherry picked from commit 951143c)
Reviewed-on: https://go-review.googlesource.com/c/go/+/189717
@dmitshur dmitshur modified the milestones: Go1.12.8, Go1.12.9 Aug 13, 2019
@dmitshur

This comment has been minimized.

Copy link
Member

@dmitshur dmitshur commented Aug 15, 2019

This backport has been approved and merged to the release branch, so I'll update the label from CherryPickCandidate to CherryPickApproved to reflect that. The rationale was that this was a serious problem (one that prevents some programs from working at all) with no workaround.

@ianlancetaylor For future backport requests, please include a short rationale for why the backport is needed, per https://golang.org/wiki/MinorReleases. You can do it when asking gopherbot to create the backport issue (gopherbot quotes the original backport request comment in the issues it creates). This will help with understanding the state of cherry picks during the release process. Thank you.

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Aug 15, 2019

The (short) rationale is in the original issue, #33555. My apologies for not including it in the comment about the backport request.

@dmitshur

This comment has been minimized.

Copy link
Member

@dmitshur dmitshur commented Aug 15, 2019

Not a problem and thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.