Skip to content

/go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: simplify validPort after CL 189258 #33600

Open
bradfitz opened this issue Aug 12, 2019 · 1 comment

Comments

@bradfitz
Copy link
Member

commented Aug 12, 2019

https://go-review.googlesource.com/c/go/+/189258 pushes some URL validation down into net/url that was previously only done in net/http.

We can remove net/http's at this point.

/cc @FiloSottile

@andybons andybons added help wanted NeedsFix labels Aug 12, 2019

@andybons andybons added this to the Go1.14 milestone Aug 12, 2019

dphan72 added a commit to dphan72/go that referenced this issue Aug 13, 2019

@dphan72
net/http: remove redundant port validation 
The URL port is already checked in net/url, so we can remove the redundant validation in net/http.

Fixes golang#33600
c19afa3
@dphan72 dphan72 referenced a pull request that will close this issue Aug 13, 2019
Open
@gopherbot

This comment has been minimized.

Sign in to view
Copy link

commented Aug 13, 2019

Change https://golang.org/cl/190057 mentions this issue: net/http: remove redundant port validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsFix help wanted
Projects
None yet
Milestone
  Go1.14
3 participants
@bradfitz @gopherbot @andybons
You can’t perform that action at this time.