Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upnet/http: simplify validPort after CL 189258 #33600
Closed
Labels
Milestone
Comments
dphan72
added a commit
to dphan72/go
that referenced
this issue
Aug 13, 2019
The URL port is already checked in net/url, so we can remove the redundant validation in net/http. Fixes golang#33600
This comment has been minimized.
This comment has been minimized.
|
Change https://golang.org/cl/190057 mentions this issue: |
t4n6a1ka
added a commit
to t4n6a1ka/go
that referenced
this issue
Sep 5, 2019
The URL port is already checked in net/url, so we can remove the redundant validation in net/http. Fixes golang#33600 Change-Id: I62511a452df6262d4b66180933758d34627ff9df GitHub-Last-Rev: c19afa3 GitHub-Pull-Request: golang#33611 Reviewed-on: https://go-review.googlesource.com/c/go/+/190057 Run-TryBot: Emmanuel Odeke <emm.odeke@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://go-review.googlesource.com/c/go/+/189258 pushes some URL validation down into net/url that was previously only done in net/http.
We can remove net/http's at this point.
/cc @FiloSottile