Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expvar: Map: excessive sorting in Add #33607

Open
bemehow opened this issue Aug 12, 2019 · 0 comments

Comments

@bemehow
Copy link

commented Aug 12, 2019

It looks like Map is re-sorting the keys slice on every Add even though sorting is really needed for Do and introduces overhead for simple set operations.

This overhead is showing up in when profiling via pprof

image

I'm using go version go1.12.5 darwin/amd64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.