Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: incorrect deep completions inside of composite literal #33614

Closed
stamblerre opened this issue Aug 13, 2019 · 1 comment
Closed

x/tools/gopls: incorrect deep completions inside of composite literal #33614

stamblerre opened this issue Aug 13, 2019 · 1 comment

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Aug 13, 2019

Repro:

Enable deep completions and code complete inside of the protocol.ServerCapabilities struct literal on line 78 of golang.org/x/tools/internal/lsp/general.go. gopls suggests deep completions that do not make sense in the current context.

Screen Shot 2019-08-13 at 12 38 40 AM

/cc @muirrn

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Aug 13, 2019

Change https://golang.org/cl/190097 mentions this issue: internal/lsp: don't deep complete struct field names

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.